Align PIF generation for user-authored modulemaps with native build system #9295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
owenv
force-pushed
the
owenv/custom-modulemap
branch
from
56108a0 to
eabac8b
Compare
jakepetroules
approved these changes
Oct 28, 2025
|
@swift-ci test |
owenv
force-pushed
the
owenv/custom-modulemap
branch
from
eabac8b to
4167a10
Compare
|
@swift-ci test |
|
Nice, this looks like it will help the plug-in tool generated module map as well (once we discover its path properly in TargetSourcesBuider). If someone wants to generate an apinote, they will need to make sure the module map is right next to it. |
dschaefer2
approved these changes
Oct 28, 2025
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Build was relying on hand-authored module maps being discovered in include directories, while the old build system always passed them using -fmodule-map-file as well. This isn't ideal, but packages like Foundation rely on this to avoid clashes with modules that ship in the toolchain, so for now we align the behavior for compatibility with existing code.
Closes #9290