Skip to content

Add functional test for swift test --sanitize --filter failure #9547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viditgupta-official wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −0
Open

Add functional test for swift test --sanitize --filter failure #9547

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c57d3e
Add functional test for swift test --sanitize --filter failure
Viditgupta-official Dec 28, 2025
9d591ab
Add functional test for swift test --sanitize --filter failure
Viditgupta-official Dec 29, 2025
d28a226
Update Tests/FunctionalTests/TestDiscoveryTests.swift
Viditgupta-official Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Tests/FunctionalTests/TestDiscoveryTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,4 +319,26 @@ struct TestDiscoveryTests {
buildSystem == .swiftbuild && ProcessInfo.hostOperatingSystem == .windows
}
}
@Test(arguments: SupportedBuildSystemOnAllPlatforms)
func testWithSanitizeAndFilterFailsWithPlatformPolicyViolation(
_ buildSystem: BuildSystemProvider.Kind
) async throws {
#if os(macOS)
try await withKnownIssue(
Copy link
Contributor

@stmontgomery stmontgomery Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation looks off; I'd expect the body of this whole function to be indented one level

"Fails due to swiftpm-xctest-helper (Xcode tool) violating platform sanitizer policy (#9546, rdar://168234231)"
Copy link
Contributor

@stmontgomery stmontgomery Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part I commented on/suggested, and that part LGTM! Thanks

) {
try await fixture(name: "Miscellaneous/TestDiscovery/Simple") { fixturePath in
let (_, stderr) = try await executeSwiftTest(
fixturePath,
extraArgs: ["--sanitize", "address", "--filter", "testExample"],
buildSystem: buildSystem
)

#expect(stderr.contains("Sanitizer load violates platform policy"))
}
}
#else
throw SkipTest("Sanitizer + filter behavior is macOS-specific")
Copy link
Contributor

@stmontgomery stmontgomery Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd generally recommend an .enabled(if:) for expressing that a particular test is only relevant on certain platforms

#endif

}