[cxx-interop] Support nested classes in reverse interop #79045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out we already had most of the building blocks given we already support nested structs. rdar://143343490
Xazax-hun
requested review from
zoecarver,
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
Jan 30, 2025
Comment on lines
+16
to
+21
| int main() { | ||
| using namespace Classes; | ||
| auto x = makeRecordConfig(); | ||
| RecordConfig::File::Gate y = x.getGate(); | ||
| RecordConfig::AudioFormat z = x.getFile().getFormat(); | ||
| } |
There was a problem hiding this comment.
Can you do more in this test here? Some things I can think of:
- Directly instantiate nested classes (i.e., referring to constructors)
- Call some methods and computed properties of nested classes (which you'll need to define)
- Assert some things about the values of
y.prop(should be equal to-80) andz(should beRecordConfig::AudioFormat::ALAC).
| @@ -0,0 +1,31 @@ | |||
| // RUN: %empty-directory(%t) | |||
| // RUN: %target-swift-frontend %s -enable-library-evolution -typecheck -module-name Classes -clang-header-expose-decls=all-public -emit-clang-header-path %t/classes.h | |||
| // RN: %FileCheck %s < %t/structs.h | |||
There was a problem hiding this comment.
Is this a typo?
Suggested change
| // RN: %FileCheck %s < %t/structs.h | |
| // RUN: %FileCheck %s < %t/classes.h |
And I don't see any // CHECK statements in this file. What is this supposed to do?
I was also going to ask whether there's any way to check the textual contents of the C++ header file generated from this Swift code (similar to the -module-interface.swift files for many forward interop test cases), but I suspect that's what you mean to do here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we already had most of the building blocks given we already support nested structs.
rdar://143343490