[6.1] Fix swift::areUsesWithinValueLifetime for guaranteed values #79091
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To find if all the uses are within a guaranteed value, we should find all borrow introducers. swift::findOwnershipReferenceAggregate looks only through forwarding operations with single operands. For simplicity, continue using swift::findOwnershipReferenceAggregate, but return false when it does not find a borrow introducer.
|
@swift-ci test |
meg-gupta
changed the title
tbkka
approved these changes
Jan 31, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: To find if all the uses are within a guaranteed value, we should find all borrow introducers.
swift::findOwnershipReferenceAggregate looks only through forwarding operations with single operands.
For simplicity, continue using swift::findOwnershipReferenceAggregate, but return false when it does not find a borrow introducer.
Scope: Regression from #78616
Original PRs: #79089
Risk: Low. Adds bailout and prevents a compiler crash
Testing: swift ci testing
Reviewers: @nate-chandler