SE-495: Make @c an official feature
#85122
Merged
+119
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
CodaFi,
DougGregor,
Xazax-hun,
bnbarham,
egorzhdan,
fahadnayyar,
hamishknight,
hborla,
hnrklssn,
j-hui,
rintaro,
slavapestov,
susmonteiro,
xedin and
zoecarver
as code owners
|
@swift-ci Please smoke test |
|
🎉 |
DougGregor
approved these changes
Oct 27, 2025
include/swift/Basic/Features.def
Outdated
Comment on lines
279
to
280
| LANGUAGE_FEATURE(CDecl, 495, "C compatible functions and enums with @c") | ||
| LANGUAGE_FEATURE(CImplementation, 495, "C compatible functions and enums with @c") |
There was a problem hiding this comment.
Can we remove these two language features entirely? One can use #if hasAttribute(c) to detect the availability of this feature, we don't need anything more.
There was a problem hiding this comment.
Should we keep the CDecl one for the backwards compatibility of swiftinterfaces? That check wouldn't be perfect either since the attribute name changed but not the feature name.
There was a problem hiding this comment.
If we emitted swift interfaces that had $CDecl checks, then we can keep the feature around. I didn't think we did, though
xymus
requested review from
AnthonyLatsis,
jckarter and
rjmccall
as code owners
xymus
force-pushed
the
official-c-attr
branch
from
510eeaa to
0a28123
Compare
|
@swift-ci Please smoke test |
xymus
force-pushed
the
official-c-attr
branch
from
0a28123 to
94113f4
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark both
CDeclandCImplementationas official language features. Update tests with the changes to the compatibility header and diagnostics.rdar://148471584