[rbi] When translating a Store, make sure to require src even if the value being stored is Sendable #85164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value being stored is Sendable This is important to ensure that we require the base of src if the src is non-Sendable (e.x.: a non-Sendable box). rdar://163322459 swiftlang#85107
|
@swift-ci smoke test |
slavapestov
approved these changes
Oct 27, 2025
jamieQ
reviewed
Oct 28, 2025
| // expected-ni-ns-note @-2 {{sending task-isolated 'x' to @concurrent global function 'useValueAsyncConcurrent' risks causing data races between @concurrent and task-isolated uses}} | ||
| } | ||
|
|
||
| enum RequireSrcWhenStoringEvenWhenSendable { |
There was a problem hiding this comment.
any chance the solution here can be extended to address this case as well:
// https://github.com/swiftlang/swift/issues/82827
@MainActor
func test_82827() {
var s = 1
Task {
for _ in 0..<100 {
s += 1
}
}
Task.detached { _ = s } // not diagnosed
}or is that a separate problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important to ensure that we require the base of src if the src is non-Sendable (e.x.: a non-Sendable box).
rdar://163322459
#85107