Add a BuiltinGenericType base class. #85169
Conversation
|
@swift-ci Please test |
| SubstitutionMap subs, | ||
| bool validate) { | ||
| if (!subs.getGenericSignature()->isEqual(getBuiltinGenericSignature(C, kind))) { | ||
| return ErrorType::get(BuiltinUnboundGenericType::get(kind, C)); |
There was a problem hiding this comment.
Shouldn't this be an ASSERT? What is the caller expected to do if they receive an ErrorType?
There was a problem hiding this comment.
I tried removing the ErrorType formation, and some diagnostic tests started failing, so it appears that some parts of Sema throw type bindings in here and rely on this logic for diagnostics.
There was a problem hiding this comment.
Can you move the ErrorType formation up to the affected callers then?
There was a problem hiding this comment.
(It would also be cleaner if this method always returned the right type of Type, instead of just Type itself.)
Builtin.FixedArray was introduced as the first generic builtin type, with special case handling in all the various recursive visitors. Introduce a base class, and move the handling to that base class, so it is easier to introduce other generic builtins in the future.
jckarter
force-pushed
the
builtin-generic-base-class
branch
from
8d58b68 to
cf5f7c8
Compare
|
@slavapestov I added caches and removed the assertion from CSSimplify; how's this look now? I can look into chasing down the ErrorType clients in a follow-up. |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
2 participants
Builtin.FixedArray was introduced as the first generic builtin type, with special case handling in all the various recursive visitors. Introduce a base class, and move the handling to that base class, so it is easier to introduce other generic builtins in the future.