Skip to content

[Test] Disable objc_getClass.NotPresent on macOS 10.15. #86152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeash wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −20
Open

[Test] Disable objc_getClass.NotPresent on macOS 10.15. #86152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions test/Interpreter/SDK/objc_getClass.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ testSuite.test("ResilientNSObject")
expectEqual(ResilientSubclassOfConcreteNSObject().subvalue.i, 7)
}

testSuite.test("NotPresent") {
testSuite.test("NotPresent")
.skip(.osxMinorRange(10, 0...15, reason: "test crashes, runtime fix not available on old OSes"))
.code {
// This class does not exist.
expectNil(NSClassFromString("main.ThisClassDoesNotExist"));

Expand All @@ -256,25 +258,20 @@ testSuite.test("NotPresent") {
// Swift.Int is not a class type.
expectNil(NSClassFromString("Si"))

if #available(StdlibDeploymentTarget 5.3, *) {
// Mangled names with byte sequences that look like symbolic references
// should not be demangled. Use indirect references to test. Direct
// references often resolve to readable memory, and then the data there
// often looks like a descriptor with an unknown kind and the lookup code
// then fails gracefully. With an indirect reference, the indirected pointer
// is typically garbage and dereferencing it will crash.
expectNil(NSClassFromString("\u{2}badnews"));
expectNil(NSClassFromString("$s\u{2}badnews"));
expectNil(NSClassFromString("_T\u{2}badnews"));
}

if #available(StdlibDeploymentTarget 5.3, *) {
// Correct mangled names with additional text afterwards should not resolve.
expectNil(NSClassFromString("_TtC4main20MangledSwiftSubclass_"))
expectNil(NSClassFromString("_TtC4main22MangledSwiftSuperclassXYZ"))
expectNil(NSClassFromString("_TtC4main19MangledObjCSubclass123"))
expectNil(NSClassFromString("_TtC4main21MangledObjCSuperclasswhee"))
}
// Mangled names with byte sequences that look like symbolic references
// should not be demangled. Use indirect references to test. Direct
// references often resolve to readable memory, and then the data there
// often looks like a descriptor with an unknown kind and the lookup code
// then fails gracefully. With an indirect reference, the indirected pointer
// is typically garbage and dereferencing it will crash.
expectNil(NSClassFromString("\u{2}badnews"));
expectNil(NSClassFromString("$s\u{2}badnews"));
expectNil(NSClassFromString("_T\u{2}badnews"));
// Correct mangled names with additional text afterwards should not resolve.
expectNil(NSClassFromString("_TtC4main20MangledSwiftSubclass_"))
expectNil(NSClassFromString("_TtC4main22MangledSwiftSuperclassXYZ"))
expectNil(NSClassFromString("_TtC4main19MangledObjCSubclass123"))
expectNil(NSClassFromString("_TtC4main21MangledObjCSuperclasswhee"))
}

runAllTests()