Skip to content

Conversation

@Jiaxu-Li
Copy link

  • Explanation:
    Fix VersionParser::parseVersionString to stop passing DiagnosticEngine* as the skipQuote argument to splitVersionComponents. The implicit pointer-to-bool conversion was effectively making skipQuote true, advancing Loc by one character and shifting version component SourceRanges, which can misplace diagnostics and contribute to cascading errors.

  • Scope:
    Diagnostic-only change. Does not alter version parsing semantics, only the computed source locations for diagnostics emitted from this path. Unlikely to break existing code; may require updating tests that assert exact caret ranges.

  • Issues:
    N/A

  • Original PRs:
    N/A

  • Risk:
    Low. Main risk is test expectation churn around diagnostic ranges; runtime behavior and accepted syntax should be unchanged.

  • Testing:
    Not tested yet.

  • Reviewers:
    N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant