Add support to show objc selector #86173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMostfa
requested review from
hamishknight,
hborla,
rintaro,
slavapestov and
xedin
as code owners
iMostfa
force-pushed
the
add-support-to-copy-objc-selector
branch
from
f7449c2 to
ff1073e
Compare
iMostfa
force-pushed
the
add-support-to-copy-objc-selector
branch
from
ff1073e to
0a6aea9
Compare
iMostfa
changed the title
- Add `source.request.objc.selector` request handler that returns the Objective-C selector for @objc methods - Fix inverted condition in getInt64 check for offset parameter - Add `objc-selector` request support to sourcekitd-test for testing - Add tests for simple methods, parameterized methods, and custom selectors This implements a direct sourcekitd request approach instead of modeling it as a refactoring action, providing a cleaner API for retrieving Objective-C selectors.
iMostfa
added a commit
to iMostfa/sourcekit-lsp
that referenced
this pull request
Jan 12, 2026
This updates the implementation to use `source.request.objc.selector` directly instead of intercepting a refactoring action. Changes: - ShowObjCSelector.swift: Call `source.request.objc.selector` and read the selector from `key.text` in the response - ShowObjCSelectorCommand.swift: Remove actionString field since we're not using refactoring - SwiftLanguageService.swift: Show "Show Objective-C Selector" action for methods/functions/constructors instead of checking for a non-existent refactoring action - sourcekitd_uids.swift: Add `objcSelector` UID for the new request This aligns with swiftlang/swift#86173 which implements the feature as a standalone request rather than a refactoring action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: swiftlang/sourcekit-lsp#2145
along with: swiftlang/sourcekit-lsp#2399
example.mov
Add Copy Objective-C Selector Refactoring
This PR adds a new refactoring action that allows users to copy the Objective-C selector from Swift methods marked with @objc or @objcMembers
SourceKit API (SwiftSourceDocInfo.cpp:2888-2974):
Request Handling (Requests.cpp:1767-1813):