Skip to content

[Lexer] Close comment on //*/ instead of opening a nested one #86239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yyoungbash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Lexer] Close comment on //*/ instead of opening a nested one #86239

yyoungbash wants to merge 1 commit into from

Conversation

@yyoungbash
Copy link

@yyoungbash yyoungbash commented Dec 30, 2025

Resolves #44163.

@yyoungbash yyoungbash mentioned this pull request Dec 30, 2025
Open
@yyoungbash
Copy link
Author

yyoungbash commented Dec 30, 2025

This PR is paired with swiftlang/swift-syntax#3222.

@yyoungbash
Copy link
Author

yyoungbash commented Jan 7, 2026

@hamishknight @DougGregor could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SR-1554] //*/ does not close multi-line comment

1 participant

@yyoungbash