Skip to content

Conversation

@kartikangiras
Copy link

Description

I have added getBuildBinarypath method which uses swift-build --show-bin-path for dynamic path resolution.

Issue: #1830

Proof Manifests:
kartik@Macbook-4 test % swift build --show-bin-path /Users/kartik/oss/vscode-swift/assets/test/.build/arm64-apple-macosx/debug

kartik@Macbook-4 test % swift build --show-bin-path --build-system swiftbuild /Users/kartik/oss/vscode-swift/assets/test/.build/arm64-apple-macosx/Products/Debug

kartik@Macbook-4 test % swift build --show-bin-path --configuration release /Users/kartik/oss/vscode-swift/assets/test/.build/arm64-apple-macosx/release

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

Copy link
Contributor

@plemarquand plemarquand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the contribution!

The windows CI job isn't passing because of
swiftlang/swift#86191, but once we have a working windows nightly I’ll rekick CI and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants