-
Notifications
You must be signed in to change notification settings - Fork 90
Show progress for package description tasks on activation #2028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
plemarquand
merged 2 commits into
swiftlang:main
from
plemarquand:show-dep-startup-progress-3
Jan 12, 2026
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the VS Code Swift open source project | ||
| // | ||
| // Copyright (c) 2021-2025 the VS Code Swift project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of VS Code Swift project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| import * as vscode from "vscode"; | ||
|
|
||
| import { FolderContext } from "../../FolderContext"; | ||
| import { PackageContents, SwiftPackage } from "../../SwiftPackage"; | ||
| import { SwiftTaskProvider, createSwiftTask } from "../../tasks/SwiftTaskProvider"; | ||
| import { packageName } from "../../utilities/tasks"; | ||
| import { executeTaskWithUI, updateAfterError } from "../utilities"; | ||
|
|
||
| /** | ||
| * Configuration for executing a Swift package command | ||
| */ | ||
| export interface SwiftPackageCommandConfig { | ||
| /** The Swift command arguments (e.g., ["package", "show-dependencies", "--format", "json"]) */ | ||
| args: string[]; | ||
| /** The task name for the SwiftTaskProvider */ | ||
| taskName: string; | ||
| /** The UI message to display during execution */ | ||
| uiMessage: string; | ||
| /** The command name for error messages */ | ||
| commandName: string; | ||
| } | ||
|
|
||
| /** | ||
| * Execute a Swift package command and return the parsed JSON output | ||
| * @param folderContext folder to run the command in | ||
| * @param config command configuration | ||
| * @returns parsed JSON output from the command | ||
| */ | ||
| export async function executeSwiftPackageCommand<T>( | ||
| folderContext: FolderContext, | ||
| config: SwiftPackageCommandConfig, | ||
| token?: vscode.CancellationToken | ||
| ): Promise<T> { | ||
| const task = createSwiftTask( | ||
| config.args, | ||
| config.taskName, | ||
| { | ||
| cwd: folderContext.folder, | ||
| scope: folderContext.workspaceFolder, | ||
| packageName: packageName(folderContext), | ||
| presentationOptions: { reveal: vscode.TaskRevealKind.Silent }, | ||
| dontTriggerTestDiscovery: true, | ||
| group: vscode.TaskGroup.Build, | ||
| }, | ||
| folderContext.toolchain, | ||
| undefined, | ||
| { readOnlyTerminal: true } | ||
| ); | ||
|
|
||
| const outputChunks: string[] = []; | ||
| task.execution.onDidWrite((data: string) => { | ||
| outputChunks.push(data); | ||
| }); | ||
|
|
||
| const success = await executeTaskWithUI( | ||
| task, | ||
| config.uiMessage, | ||
| folderContext, | ||
| false, | ||
| false, | ||
| token | ||
| ); | ||
| updateAfterError(success, folderContext); | ||
|
|
||
| const output = outputChunks.join(""); | ||
|
|
||
| if (!success) { | ||
| throw new Error(output); | ||
| } | ||
|
|
||
| if (!output.trim()) { | ||
| throw new Error(`No output received from swift ${config.commandName} command`); | ||
| } | ||
|
|
||
| try { | ||
| const trimmedOutput = SwiftPackage.trimStdout(output); | ||
| const parsedOutput = JSON.parse(trimmedOutput); | ||
|
|
||
| // Validate the parsed output is an object | ||
| if (!parsedOutput || typeof parsedOutput !== "object") { | ||
| throw new Error(`Invalid format received from swift ${config.commandName} command`); | ||
| } | ||
|
|
||
| return parsedOutput as T; | ||
| } catch (parseError) { | ||
| throw new Error( | ||
| `Failed to parse ${config.commandName} output: ${parseError instanceof Error ? parseError.message : "Unknown error"}` | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Run `swift package describe` inside a folder | ||
| * @param folderContext folder to run describe for | ||
| */ | ||
| export async function describePackage( | ||
| folderContext: FolderContext, | ||
| token?: vscode.CancellationToken | ||
| ): Promise<PackageContents> { | ||
| const result = await executeSwiftPackageCommand<PackageContents>( | ||
| folderContext, | ||
| { | ||
| args: ["package", "describe", "--type", "json"], | ||
| taskName: SwiftTaskProvider.describePackageName, | ||
| uiMessage: "Describing Package", | ||
| commandName: "package describe", | ||
| }, | ||
| token | ||
| ); | ||
|
|
||
| return result; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.