Mark swift-testing test runs as started immediately#2079
Open
plemarquand wants to merge 2 commits intoswiftlang:mainfrom
Open
Mark swift-testing test runs as started immediately#2079plemarquand wants to merge 2 commits intoswiftlang:mainfrom
plemarquand wants to merge 2 commits intoswiftlang:mainfrom
Conversation
Un-reverts f2eb5de (swiftlang#2060), which marked tests runs as started for both XCTest and swift-testing immediately, but only when not debugging. This version marks tests as started immediately both when debugging and when running without the debugger. Original commit message follows. Previously we were waiting for all parameterized test items to be emitted on the JSON event stream before starting the `vscode.TestRun`. This limitation was in place to ensure we had all the test items in test request sent to VSCode, as we couldn't add test items after a run had started. That requirement seems to have been relaxed, or we were just not refreshing the test explorer correctly after dynamically adding items, but regardless it looks like we can dynamically add items now. This means we can correctly mark a test run as "started" immediately when the user starts compiling a test like we do with XCTest, making the two testing libraries the same in this regard. It also simplifies the code, allowing us to accept and inject new parameterized test items at any time during a run.
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
added
the
full-test-run
plemarquand
force-pushed
the
no-more-wait-for-parameterized-tests-take-2
branch
from
63c38fc to
20ffc4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Un-reverts f2eb5de (#2060), which marked tests runs as started for both XCTest and swift-testing immediately, but only when not debugging. This version marks tests as started immediately both when debugging and when running without the debugger. Original commit message follows.
Previously we were waiting for all parameterized test items to be emitted on the JSON event stream before starting the
vscode.TestRun.This limitation was in place to ensure we had all the test items in test request sent to VSCode, as we couldn't add test items after a run had started.
That requirement seems to have been relaxed, or we were just not refreshing the test explorer correctly after dynamically adding items, but regardless it looks like we can dynamically add items now.
This means we can correctly mark a test run as "started" immediately when the user starts compiling a test like we do with XCTest, making the two testing libraries the same in this regard. It also simplifies the code, allowing us to accept and inject new parameterized test items at any time during a run.
Tasks