Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Calculate gas fee in USD #473

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(ui): Calculate gas fee in USD #473

wants to merge 2 commits into from

Conversation

swimdrew
Copy link
Contributor

@swimdrew swimdrew commented Oct 27, 2022 •
edited
Loading

Notion ticket

Checklist

  • Github project and label have been assigned
  • Tests have been added or are unnecessary
  • Docs have been updated or are unnecessary
  • Preview deployment works (visit the Cloudflare preview URL)
  • Manual testing in #product-testing completed or unnecessary
  • New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
  • When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

@swimdrew swimdrew added the feature New feature or request label Oct 27, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 27, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1bbdab
Status: ✅  Deploy successful!
Preview URL: https://61912075.swim-ui.pages.dev
Branch Preview URL: https://ui-add-gasfee-usd-estimation.swim-ui.pages.dev

View logs

@github-actions
Copy link

✨ Deployment complete! Take a peek over at https://28fe3f90.ui-storybook.pages.dev

@swimdrew swimdrew marked this pull request as ready for review October 28, 2022 13:53
@wormat wormat changed the title feat(ui): Caluclate gas fee in USD feat(ui): Calculate gas fee in USD Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wormat wormat Awaiting requested review from wormat

@ramenuncle ramenuncle Awaiting requested review from ramenuncle

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swimdrew