-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
### What Commit essential linting and formatting config from our favourite IDE to the repository. The aim is to have the same config across the team and across IDE so we avoid dealing with changes that shouldn't be part of our PR. * Add config for Intellij and vscode - Remove gitignore on .idea config - Disable prettier on MDX files - Use LF as default line separator - Enable format on save * Run `prettier --write "**/*.{**/*,*}.{js,ts,jsx,tsx,scss,css,html,json}"` * Remove prettier-ignore in mdx files About MDX: Disable formatting totally, as the maximum printWidth rule conflicts with MDX syntax about new line = `<p>`. Latest issue that we had: #2128 . Issue on Prettier repository: prettier/prettier#12209 If this wouldn't be enough, the second option is to ensure that our files are checked before committed with a git hook: https://github.com/lint-staged/lint-staged For review: you can do it commit by commit. --------- Co-authored-by: Philipp Gfeller <[email protected]>
- Loading branch information
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
{ | ||
"editor.formatOnSave": true, | ||
"editor.defaultFormatter": "esbenp.prettier-vscode", | ||
"[mdx]": { | ||
"editor.defaultFormatter": null, | ||
"editor.formatOnSave": false | ||
}, | ||
"files.eol": "\n" | ||
} |