Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rating component #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Rating component #299

wants to merge 2 commits into from

Conversation

Phinome
Copy link

@Phinome Phinome commented Aug 3, 2024

  1. added rating component
  2. fixed cli helper message
  3. added some necessary files

please help CR, thx.

feel free to me if you have any question.

Best Regards,

Phinome

@Phinome
Copy link
Author

Phinome commented Aug 19, 2024

no body care?

}

function RatingItem(props: RatingItemProps) {
const isFilled = props.highlightSelectedOnly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not reactive.

);

if (props.readOnly) {
return <span {...props.labelProps}>{container}</span>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notn reactive.

name: "Rating",
});

const valueRounded = roundValueToPrecision(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non reactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants