chore(release): add release images and notes for v3.38.0#5271
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughAdds four app shortcuts to the web manifest linking to hash-based routes, adds an effect in useDashboard to auto-open "My Assignments" when the URL hash contains action=assignments, and changes zero-width-space stripping in AYF assignment-type lookups from regex replace to replaceAll. ChangesPWA Shortcut Deep Link
AYF Label Zero-Width-Space Normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant Browser
participant useDashboard
User->>Browser: Selects "My Assignments" shortcut
Browser->>useDashboard: Loads dashboard with hash action=assignments
useDashboard->>useDashboard: Reads globalThis.location.hash
useDashboard->>useDashboard: setIsMyAssignmentOpen(true)
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ux-git
changed the title
ux-git
force-pushed
the
feat/release-images-v3.38.0
branch
from
6b24400 to
c79129b
Compare
ux-git
force-pushed
the
feat/release-images-v3.38.0
branch
from
c79129b to
21c46ca
Compare
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/pages/dashboard/useDashboard.tsx (1)
62-62: 🚀 Performance & Scalability | 🔵 TrivialConsider exact param match instead of substring
includes.
hash.includes('action=assignments')would also match unintended values likeaction=assignmentsFoo. Parsing the hash query string (e.g. viaURLSearchParams) would be more precise.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/dashboard/useDashboard.tsx` at line 62, The hash check in useDashboard is too loose because hash.includes('action=assignments') can match unintended values like action=assignmentsFoo. Update the logic in useDashboard to parse the hash query string with a precise matcher such as URLSearchParams and compare the action parameter exactly against assignments, keeping the existing behavior in the same branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/dashboard/useDashboard.tsx`:
- Around line 61-64: The hash-driven drawer open logic in useDashboard should
clear the consumed action flag after opening the assignments drawer. Update the
effect/handler around the hash check so that when globalThis.location.hash
contains action=assignments and setIsMyAssignmentOpen(true) is called, the hash
is immediately rewritten without that flag (or otherwise sanitized) to prevent
the drawer from reopening on refresh or return navigation. Keep the fix
localized to useDashboard and the existing hash parsing logic.
- Around line 60-65: The hash check in useDashboard only runs on mount because
setIsMyAssignmentOpen is stable, so the assignments drawer won’t open when the
existing app window is reused and only the hash changes. Update useDashboard to
also react to location hash changes, for example by adding a hashchange listener
(or equivalent router-driven location subscription) alongside the initial mount
check, and keep the existing action=assignments logic in the shared handler.
---
Nitpick comments:
In `@src/pages/dashboard/useDashboard.tsx`:
- Line 62: The hash check in useDashboard is too loose because
hash.includes('action=assignments') can match unintended values like
action=assignmentsFoo. Update the logic in useDashboard to parse the hash query
string with a precise matcher such as URLSearchParams and compare the action
parameter exactly against assignments, keeping the existing behavior in the same
branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 266b64aa-a88e-496c-9b82-04bbfa4a8828
⛔ Files ignored due to path filters (11)
public/img/shortcuts/shortcut-ministry-report.pngis excluded by!**/*.png,!**/*.pngpublic/img/shortcuts/shortcut-ministry-report.svgis excluded by!**/*.svg,!**/*.svgpublic/img/shortcuts/shortcut-my-assignments.pngis excluded by!**/*.png,!**/*.pngpublic/img/shortcuts/shortcut-my-assignments.svgis excluded by!**/*.svg,!**/*.svgpublic/img/shortcuts/shortcut-upcoming-events.pngis excluded by!**/*.png,!**/*.pngpublic/img/shortcuts/shortcut-upcoming-events.svgis excluded by!**/*.svg,!**/*.svgpublic/img/shortcuts/shortcut-weekly-schedules.pngis excluded by!**/*.png,!**/*.pngpublic/img/shortcuts/shortcut-weekly-schedules.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/whats-new-color-schemes.svgis excluded by!**/*.svg,!**/*.svgsrc/assets/img/whats-new-homescreen-shortcuts.svgis excluded by!**/*.svg,!**/*.svgsrc/locales/en/release_notes.jsonis excluded by!**/*.json
📒 Files selected for processing (3)
public/manifest.webmanifestsrc/pages/dashboard/useDashboard.tsxsrc/services/app/sources.ts
|
Tick the box to add this pull request to the merge queue (same as
|
rhahao
approved these changes
Jul 1, 2026
organized-app
 |
||||||||||||||||||||||||||||
| Project |
organized-app
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 10s |
| Commit |
|
| Committer | ux-git |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
1
|
| View all changes introduced in this branch ↗︎ | |
Member
|
🎉 This PR is included in version 3.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two new "What's New" release images and release notes for version 3.38.0:
Also adds an improvement note for the new school for congregation elders credit hour preset.
Type of change
Checklist: