Store the DG Basis in the Block. #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dg_basis will be used to determine the topology of the Block as well as the Spectral::Basis used for a Mesh on an Element of the Block. It is default initialized to Spectral::Basis::Legendre as that has been the previous choice.
nilsdeppe
previously requested changes
Mar 3, 2025
Comment on lines
+360
to
+367
| { | ||
| const Block<2> rhs( | ||
| identity_map.get_clone(), 3, neighbors, "Identity", | ||
| {{Spectral::Basis::Chebyshev, Spectral::Basis::Legendre}}); | ||
| CHECK(rhs.dg_basis() == | ||
| std::array{Spectral::Basis::Chebyshev, Spectral::Basis::Legendre}); | ||
| CHECK(block != rhs); | ||
| } |
There was a problem hiding this comment.
Could you add a test for Ylm basis? Mostly just to provide an example for folks in the future with a 2d basis.
There was a problem hiding this comment.
Such a test does not make sense until the next PR which fixes assumptions about external boundaries. So I can either add the commits for that PR to this one, or you can wait, doesn't matter to me...
|
Just wait then!!
…On Mon, Mar 3, 2025, 13:27 Lawrence Kidder ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/Unit/Domain/Test_Block.cpp
<#6510 (comment)>
:
> + {
+ const Block<2> rhs(
+ identity_map.get_clone(), 3, neighbors, "Identity",
+ {{Spectral::Basis::Chebyshev, Spectral::Basis::Legendre}});
+ CHECK(rhs.dg_basis() ==
+ std::array{Spectral::Basis::Chebyshev, Spectral::Basis::Legendre});
+ CHECK(block != rhs);
+ }
Such a test does not make sense until the next PR which fixes assumptions
about external boundaries. So I can either add the commits for that PR to
this one, or you can wait, doesn't matter to me...
—
Reply to this email directly, view it on GitHub
<#6510 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHHPFSS3CHOJRWMBUNIAJD2SSUKJAVCNFSM6AAAAABYEIABJCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNJVGA3TMNZVGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dg_basis will be used to determine the topology of the Block as well as the Spectral::Basis used for a Mesh on an Element of the Block. It is default initialized to Spectral::Basis::Legendre as that has been the previous choice.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments