feat: Mount manager #1977
feat: Mount manager #1977
Conversation
|
Thank you so much for your PR! This is a feature I've always wanted to support but just didn't have the time to complete, so I'm really happy to see someone take it up, especially since you're the original author of I think it's best to offer this as a plugin rather than a built-in feature, and expose the API for getting mount information to Lua. This way, it can also benefit other plugins. If many users need it, we can offer it as a built-in plugin, but initially, it's better to maintain it as a separate repository. So that we can get quick issue fixes independent of Yazi's release cycle, just like with the I'm more than happy to explore any blockers in implementing this via the plugin system, and if necessary, I can provide any missing plugin APIs — just let me know! |
|
Thank you for such an answer! I get your point and agreed that this functionality is possible to implement with extended API! I'll create list of required API and we'll decide how to implement it better. |
|
I understand your perspective and agree that leveraging an extended API is a viable approach. However, I believe that integrating a mount manager directly into the Rust codebase is essential for achieving a robust and seamless user experience, especially given the limitations of the current Lua API in delivering a sophisticated user interface. I couldn't imagine situation when mount manager is not required for user. My suggestion is to implement the core mount manager functionality in Rust, ensuring multi-platform support for essential features such as viewing mount points and unmounted drives, navigating to mount points, and performing mount and unmount operations. This would provide a solid foundation for users across different systems. Subsequently, we can develop a Lua API to allow for further customization and extension through functional plugins. This hybrid approach would combine the stability and performance of Rust with the flexibility of Lua, catering to both basic and advanced user needs. I look forward to collaborating and contributing on this and exploring how we can best implement these features to enhance the project. |
sxyazi
force-pushed
the
main
branch
2 times, most recently
from
1394fb4 to
62ac224
Compare
|
@sxyazi hi, I've made plugin 😄 It is in early stage, I'll debug it a little bit and make it public. It is LUA plugin with Rust application. Rust app based on linux sysfs, and udisk2 via dbus. https://github.com/SL-RU/mount.yazi screencast: |
|
@sxyazi can you give some feedback please? |
|
Sorry for the delay. I did some research on supporting this across 3 platforms (Linux, macOS, Windows). Since I'm not familiar with Linux and Windows — those aren't my work systems, it took me some time. I took a look at the If you're not familiar with the Lua part, that's totally fine! You can just create a simple function for me, and I'll port it to Lua. In the meantime, I'll try to implement the device listing for macOS, as it's my work system and should be lot easier for me. Once we have that API, we can start working on the UI in the plugin. If you're not familiar with Yazi's UI plugin API, no worries — just leave it to me, and I'll provide any help needed to implement it. As for Windows, it looks like it will require calling some Windows-specific APIs. If you're familiar with those, please try to implement a function for getting the device list there as well. If not, that's fine too — we can leave it for now and wait until someone familiar with Windows platforms is available to handle it. |
|
Thank you for the reply, I'll add windows support and api for Linux. It requires dbus and udisk for mounting, but these libraries are not required to be installed on the machine, only few rust crates. |
Hi, I think mount points management is important part of file manager and because of that I want to implement that feature. This pull request is the starting point. It was mentioned here #1272 #927 . I think it cannot be fully done using plugin system and must be part of this project.
Currently there is only data from
/proc/mountsin the menu, but later it must contain data same as lsblk (including not mounted yet volumes) and from fstab (not mounted yet volumes).Functionality now is limited: only change direcory to mountpoint. In plans: mount, unmount, poweroff and show info about partition.
Keymap:
In file manager key
Mopens mount manager.In mount manager up and down scrolls;
lor<Enters>changes directory to selected. Mountpoint list is updated only when opens or arrow keys pressed, later maybe makes sense to update on timer.Only UNIX systems are supported now for demonstration purposes. But later is not a problem to add mac and win.
Please give some feedback, can it be merged in the future? Do you think it is required feature in your project?