fix : escape HTML in send-review API route email body - #23
Open
tmdeveloper007 wants to merge 1 commit into
Open
Conversation
Apply HTML entity encoding to name, email, and review fields before inserting them into the HTML email body to prevent XSS in mail clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done:
Added an escapeHtml() helper and applied it to the name, email, and review fields in the HTML email template of the send-review route. The rating stars and to recipient remain unchanged as they are server-controlled.
Changes Made:
Impact it Made:
Prevents XSS via crafted review text containing HTML tags or script content. Lint remains green.