chore : read GA_MEASUREMENT_ID from NEXT_PUBLIC_GA_ID environment variable - #5
Open
tmdeveloper007 wants to merge 1 commit into
Open
chore : read GA_MEASUREMENT_ID from NEXT_PUBLIC_GA_ID environment variable#5tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
NEXT_PUBLIC_GA_ID is already listed in EnvExample.txt but the actual gtag.js was using a hardcoded value. Read from env first with the existing hardcoded value as fallback for backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes (upstream issues disabled — no issue created).
Summary of What Has Been Done:
Updated lib/gtag.js to read the Google Analytics Measurement ID from the NEXT_PUBLIC_GA_ID environment variable instead of using a hardcoded string. The NEXT_PUBLIC_GA_ID variable is already documented in EnvExample.txt but was never wired into the code. The existing hardcoded value is kept as a fallback so local development continues to work without any env var set.
Changes Made:
Impact it Made:
Note: Please assign this PR to the
tmdeveloper007account.