Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ganache-cli with ganache #92

Closed
wants to merge 1 commit into from
Closed

Replace ganache-cli with ganache #92

wants to merge 1 commit into from

Conversation

nmlinaric
Copy link
Contributor

@nmlinaric nmlinaric commented Dec 14, 2022 •
edited
Loading

Description

Replace ganache-cli with ganache since it has been archived and moved to new repository

Related Issue Or Context

Closes: sygmaprotocol/project-backlog#37

How Has This Been Tested? Testing details.

manual tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@MakMuftic
Copy link
Contributor

@nmlinaric lgtm, but tests are failing

@nmlinaric
Copy link
Contributor Author

Changing this to draft since ganache v7 has a bug with same behaviour mentioned in this issue and there is a draft PR that should fix this behaviour

@nmlinaric nmlinaric marked this pull request as draft January 10, 2023 16:14
@nmlinaric
Copy link
Contributor Author

Closing this since it is obsolete - we're migration to hardhat

@nmlinaric nmlinaric closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@P1sar P1sar Awaiting requested review from P1sar

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmlinaric @MakMuftic