-
Notifications
You must be signed in to change notification settings - Fork 4
Pruning e2e verification #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alrxy
wants to merge
16
commits into
main
Choose a base branch
from
prune-verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6df10e3
test: prune e2e
alrxy 75ff81f
fix: lint
alrxy 7e8c63e
fix: badger scan
alrxy a45444b
fix: pruning test on non-fresh setup
alrxy 14474d5
Merge branch 'main' into prune-verification
alrxy 2f2ffa1
fix: access to badger file
alrxy 5f2fe11
fix: chmod before stop
alrxy 4f26b27
fix: offline scan for both dbs
alrxy 8fe8824
fix: remove waiting for no error before scanning
alrxy 01962c2
fix: adjust pruning envs
alrxy 893c936
fix: test stop and chmod
alrxy 7126f58
Merge branch 'main' into prune-verification
alrxy f612e19
fix: change root user
alrxy 32e393d
chore: add prescan in pruning and extend time limit to 40m
alrxy 2f3eee4
Merge remote-tracking branch 'origin/main' into crazy-goldstine-a9b85a
alrxy 785c3a4
Merge branch 'main' into prune-verification
alrxy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYNC_EPOCHSdefaults to1000even when retention is overridden to a much smaller value. With this change, users can now setRETENTION_VALSET_EPOCHSvia env, but if they forget to also setSYNC_EPOCHS, the generated config becomes invalid (sync.epochs>retention.valset-epochs) and relay startup fails due to config validation. The default should be capped/derived from retention to avoid this regression when enabling pruning settings.Useful? React with 👍 / 👎.