Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] task: Added convert message to utf8 feature #1194

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

AnthonyLaw
Copy link
Member

What was the issue?

  • The explorer transaction message field didn't support the hex string (drop first 0 bytes in message) for UTF-8.

What's the fix?

  • Added a button, so the user can switch from the default view to UTF8
  • It only supports the non-encrypted message and the payload in hex string.

Screenshoot

Screenshot 2024-09-18 at 3 23 36 PM image

@AnthonyLaw AnthonyLaw requested a review from Wayonb September 18, 2024 07:24
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for explorer-dev ready!

Name Link
🔨 Latest commit c779b5a
🔍 Latest deploy log https://app.netlify.com/sites/explorer-dev/deploys/67868b9985a7d50008949dcc
😎 Deploy Preview https://deploy-preview-1194--explorer-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Wayonb
Copy link
Contributor

Wayonb commented Sep 23, 2024

Can you fix linting?

@Wayonb
Copy link
Contributor

Wayonb commented Dec 26, 2024

Can you fix the apexcharts conflict? You will need to delete the package-lock.json to repo. Thanks.

@AnthonyLaw AnthonyLaw force-pushed the explorer/feature-convert-utf8-message branch from 5e05f66 to be54746 Compare December 30, 2024 14:56
@AnthonyLaw AnthonyLaw force-pushed the explorer/feature-convert-utf8-message branch from be54746 to 65a0630 Compare January 8, 2025 03:01
__tests__/components/fileds/MessageField.spec.js Outdated Show resolved Hide resolved
src/components/fields/MessageField.vue Outdated Show resolved Hide resolved
@AnthonyLaw AnthonyLaw requested a review from Wayonb January 14, 2025 10:00
Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@AnthonyLaw AnthonyLaw force-pushed the explorer/feature-convert-utf8-message branch from b758d2e to c779b5a Compare January 14, 2025 16:06
@AnthonyLaw AnthonyLaw merged commit 49dec96 into dev Jan 14, 2025
7 checks passed
@AnthonyLaw AnthonyLaw deleted the explorer/feature-convert-utf8-message branch January 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants