-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination enhancement #985
Conversation
✔️ Deploy Preview for explorer-dev ready! 🔨 Explore the source changes: 67f4127 🔍 Inspect the deploy log: https://app.netlify.com/sites/explorer-dev/deploys/61aec7ecc6bc460007aaf514 😎 Browse the preview: https://deploy-preview-985--explorer-dev.netlify.app/ |
27cba0a
to
d407775
Compare
d407775
to
72e5d6a
Compare
b2b90db
to
020a78f
Compare
I would not include
You will want to reduce the size the input field takes up on the UI. See the attached screenshot - the width is quite large in comparison to the entry. Even if it is prescaled to fit the max entry size, there's still quite a lot of padding on the left and right margins. I would also not allow input at the moment. If a user doesn't know the maximum amount of pages, their input might not be valid which can lead to confusion. For example, if I navigate to namespaces, it does not display the total amount of pages possible - if I enter '700', it just reloads the page. I would cap the pages at 50 for Namespaces & Mosaics (to match the limit present in the Transactions tab) until we've either moved Explorer to an independent DB, or fixed Issue #682 in REST.
A user can still input an incorrect field if the last page is not cached. |
@0x6861746366574 Checked on Mainnet, we have less than 50 pages of data for Namespaces (16 pages) & Mosaics (41 pages). Update Preview
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There are some limitations from REST, some of the data is unable to get the total records. symbol/catapult-rest#682
If the explorer is unable to get the last page from the data, it will display
..
Update
pagination
andpaginationTimeline
in pagination methodAdd
totalRecords
properties onpageInfo
use for calculate last page.advance
flag to change pagination interface, default is trueadvance
advance
false (it use for block detail page)Remove