[lightapi/python] task: add NemConnector endpoints #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLaw
changed the title
AnthonyLaw
force-pushed
the
lightapi/nem
branch
3 times, most recently
from
e60197d to
d79236b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #464 +/- ##
==========================================
+ Coverage 98.22% 98.23% +0.01%
==========================================
Files 161 163 +2
Lines 6528 6748 +220
Branches 143 143
==========================================
+ Hits 6412 6629 +217
- Misses 116 119 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gimre-xymcity
requested changes
Jul 4, 2023
| Raises NodeException on connection or content failure. | ||
| """ | ||
|
|
||
| return await self._dispatch('post', url_path, property_name, data=json.dumps(request_payload), headers={ |
There was a problem hiding this comment.
you probably want to use json= instead of data:
a) it doesn't require json.dumps
b) you don't need headers as it does that automatically
apart from that, looks ok
There was a problem hiding this comment.
good to know, that is powerful! 👍🏼
|
Do you think we should rename it, because this endpoint is only use for local node? |
Jaguar0625
force-pushed
the
dev
branch
2 times, most recently
from
901e815 to
2ee1d0e
Compare
AnthonyLaw
force-pushed
the
lightapi/nem
branch
3 times, most recently
from
a3369ee to
a59a4d9
Compare
Wayonb
requested changes
Jul 20, 2023
Wayonb
previously approved these changes
Jul 25, 2023
AnthonyLaw
force-pushed
the
lightapi/nem
branch
from
6bf98b4 to
d7d6710
Compare
…after and local/block/at
… ImportanceTransferTransaction and ConvertAccountToMultisig
…on, MosaicDefinitionTransaction and MosaicSupplyChangeTransaction
…ignatureTransaction
…ange in multisig account modification
AnthonyLaw
force-pushed
the
lightapi/nem
branch
from
5cf95c5 to
8bc15f3
Compare
AnthonyLaw
force-pushed
the
lightapi/nem
branch
from
719e08f to
5569c66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the issue?
What's the fix?