[DomCrawler] UriResolver support path with columns

symfony · Nov 14, 2023 · a92d93a · a92d93a
1 parent d2aefa5
commit a92d93a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Tests/UriResolverTest.php b/Tests/UriResolverTest.php
@@ -84,6 +84,10 @@ public static function provideResolverTests()
 
             ['foo', 'http://localhost?bar=1', 'http://localhost/foo'],
             ['foo', 'http://localhost#bar', 'http://localhost/foo'],
+
+            ['foo:1', 'http://localhost', 'http://localhost/foo:1'],
+            ['/bar:1', 'http://localhost', 'http://localhost/bar:1'],
+            ['foo/bar:1', 'http://localhost', 'http://localhost/foo/bar:1'],
         ];
     }
 }
diff --git a/UriResolver.php b/UriResolver.php
@@ -33,7 +33,7 @@ public static function resolve(string $uri, ?string $baseUri): string
         $uri = trim($uri);
 
         // absolute URL?
-        if (null !== parse_url($uri, \PHP_URL_SCHEME)) {
+        if (\is_string(parse_url($uri, \PHP_URL_SCHEME))) {
             return $uri;
         }