do not access typed property before initialization

symfony · Oct 22, 2024 · e9fbfa4 · e9fbfa4
1 parent 6375b48
commit e9fbfa4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/Tests/Transliterator/EmojiTransliteratorTest.php b/Tests/Transliterator/EmojiTransliteratorTest.php
@@ -177,4 +177,18 @@ public function testReverse()
         $this->expectException(\IntlException::class);
         EmojiTransliterator::create('emoji-en', EmojiTransliterator::REVERSE);
     }
+
+    public function testGetErrorCodeWithUninitializedTransliterator()
+    {
+        $transliterator = EmojiTransliterator::create('emoji-en');
+
+        $this->assertSame(0, $transliterator->getErrorCode());
+    }
+
+    public function testGetErrorMessageWithUninitializedTransliterator()
+    {
+        $transliterator = EmojiTransliterator::create('emoji-en');
+
+        $this->assertFalse($transliterator->getErrorMessage());
+    }
 }
diff --git a/Transliterator/EmojiTransliterator.php b/Transliterator/EmojiTransliterator.php
@@ -72,12 +72,12 @@ public function createInverse(): self
 
         public function getErrorCode(): int|false
         {
-            return $this->transliterator?->getErrorCode() ?? 0;
+            return isset($this->transliterator) ? $this->transliterator->getErrorCode() : 0;
         }
 
         public function getErrorMessage(): string|false
         {
-            return $this->transliterator?->getErrorMessage() ?? false;
+            return isset($this->transliterator) ? $this->transliterator->getErrorMessage() : false;
         }
 
         public static function listIDs(): array