Make more nullable types explicit

symfony · Mar 19, 2024 · a69a4d0 · a69a4d0
1 parent 2114101
commit a69a4d0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Command/AbstractFailedMessagesCommand.php b/Command/AbstractFailedMessagesCommand.php
@@ -185,7 +185,7 @@ protected function printPendingMessagesMessage(ReceiverInterface $receiver, Symf
     /**
      * @param string|null $name
      */
-    protected function getReceiver(/* string $name = null */): ReceiverInterface
+    protected function getReceiver(/* ?string $name = null */): ReceiverInterface
     {
         if (1 > \func_num_args() && __CLASS__ !== static::class && __CLASS__ !== (new \ReflectionMethod($this, __FUNCTION__))->getDeclaringClass()->getName() && !$this instanceof \PHPUnit\Framework\MockObject\MockObject && !$this instanceof \Prophecy\Prophecy\ProphecySubjectInterface && !$this instanceof \Mockery\MockInterface) {
             trigger_deprecation('symfony/messenger', '5.3', 'The "%s()" method will have a new "string $name" argument in version 6.0, not defining it is deprecated.', __METHOD__);

diff --git a/Handler/BatchHandlerInterface.php b/Handler/BatchHandlerInterface.php
@@ -23,7 +23,7 @@ interface BatchHandlerInterface
      * @return mixed The number of pending messages in the batch if $ack is not null,
      *               the result from handling the message otherwise
      */
-    // public function __invoke(object $message, Acknowledger $ack = null): mixed;
+    // public function __invoke(object $message, ?Acknowledger $ack = null): mixed;
 
     /**
      * Flushes any pending buffers.

diff --git a/Retry/RetryStrategyInterface.php b/Retry/RetryStrategyInterface.php
@@ -23,12 +23,12 @@ interface RetryStrategyInterface
     /**
      * @param \Throwable|null $throwable The cause of the failed handling
      */
-    public function isRetryable(Envelope $message/* , \Throwable $throwable = null */): bool;
+    public function isRetryable(Envelope $message/* , ?\Throwable $throwable = null */): bool;
 
     /**
      * @param \Throwable|null $throwable The cause of the failed handling
      *
      * @return int The time to delay/wait in milliseconds
      */
-    public function getWaitingTime(Envelope $message/* , \Throwable $throwable = null */): int;
+    public function getWaitingTime(Envelope $message/* , ?\Throwable $throwable = null */): int;
 }