Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Fix translation provider add-lines instructions #1259

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

welcoMattic
Copy link
Member

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

Mistake was done in #1217, fixed now.
In addition, I've added add-lines for Phrase Provider.

Copy link

github-actions bot commented Nov 21, 2023

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1259/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1259/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/crowdin-translation-provider:^5.3' 'symfony/loco-translation-provider:^5.3' 'symfony/lokalise-translation-provider:^5.3' 'symfony/phrase-translation-provider:^6.4' 'symfony/translation:^6.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

symfony/translation

3.3 vs 5.3
diff --git a/symfony/translation/3.3/config/packages/translation.yaml b/symfony/translation/5.3/config/packages/translation.yaml
index 05a2b3d..b3f8f9c 100644
--- a/symfony/translation/3.3/config/packages/translation.yaml
+++ b/symfony/translation/5.3/config/packages/translation.yaml
@@ -4,3 +4,4 @@ framework:
         default_path: '%kernel.project_dir%/translations'
         fallbacks:
             - en
+        providers:
5.3 vs 6.3

nicolas-grekas
nicolas-grekas previously approved these changes Nov 21, 2023
@welcoMattic welcoMattic force-pushed the fix-translation-providers-add-lines branch from 2df9395 to 4021eb7 Compare November 21, 2023 15:26
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Nov 21, 2023
…der (welcoMattic)

This PR was merged into the 6.4 branch.

Discussion
----------

[Translation] Fix Translation changelog for Phrase provider

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

Phrase provider has been added to 6.4, not 6.3

Flex recipe has been fixed in symfony/recipes#1259

Commits
-------

78fc311 Fix translation changelog for Phrase provider
@symfony-recipes-bot symfony-recipes-bot merged commit 62c644e into main Jan 18, 2024
@symfony-recipes-bot symfony-recipes-bot deleted the fix-translation-providers-add-lines branch January 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants