Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uncomment MAILER_DSN env for symfony/mailer #1352

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Nov 1, 2024

Q A
License MIT
Doc issue/PR n/a

Currently, when installing symfony/mailer, the MAILER_DSN is commented out so you get an error when trying to send an email. I feel this is a bit of a DX bummer.

I think it should default to null://null so you can start using it right away (preview in the profiler and use in your tests).

Any bridge you install for production sending would configure MAILER_DSN elsewhere (ie secrets or .env.local).

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 1, 2024 15:25
Copy link

github-actions bot commented Nov 1, 2024

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1352/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1352/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'symfony/mailer:^4.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me.

@symfony-recipes-bot symfony-recipes-bot merged commit cc3c2b1 into symfony:main Nov 1, 2024
1 of 2 checks passed
@kbond kbond deleted the mailer-env branch December 2, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants