[AssetMapper] Upgrade importmap polyfill #57565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 28, 2024
Not sure if we should backport this on 6.4 ?
nicolas-grekas
requested review from
lyrixx,
yceruto,
kbond,
chalasr,
dunglas,
OskarStark,
jderusse and
xabbuh
as code owners
nicolas-grekas
force-pushed
the
feat/upgrade-importmap-polyfill
branch
from
d5145a2
to
385d1e8
Compare
|
Thank you @smnandre. |
Kocal
reviewed
Jun 28, 2024
| private const DEFAULT_ES_MODULE_SHIMS_POLYFILL_URL = 'https://ga.jspm.io/npm:[email protected]/dist/es-module-shims.js'; | ||
| // https://generator.jspm.io/#S2NnYGAIzSvJLMlJTWEAAMYOgCAOAA | ||
| private const DEFAULT_ES_MODULE_SHIMS_POLYFILL_URL = 'https://ga.jspm.io/npm:[email protected]/dist/es-module-shims.js'; | ||
| private const DEFAULT_ES_MODULE_SHIMS_POLYFILL_INTEGRITY = 'sha384-ie1x72Xck445i0j4SlNJ5W5iGeL3Dpa0zD48MZopgWsjNB/lt60SuG1iduZGNnJn'; |
There was a problem hiding this comment.
The constant is not used anywhere, is it on purpose? Maybe a comment would have been enough?
There was a problem hiding this comment.
it's used on 7.1 so at least it's there for the merge up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we should backport this on 6.4 ?