Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed Catalan missing translations #57566

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

umigam3
Copy link
Contributor

@umigam3 umigam3 commented Jun 27, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #54947
License MIT

Reviewed Catalan translation and added some changes.

<trans-unit id="18">
        <source>Invalid or expired login link.</source>
        <target>Enllaç d'inici de sessió no vàlid o caducat.</target>
</trans-unit>
<trans-unit id="19">
        <source>Too many failed login attempts, please try again in %minutes% minute.</source>
        <target>Massa intents d'inici de sessió fallits, si us plau torneu-ho a provar en %minutes% minut.</target>
</trans-unit>
<trans-unit id="20">
       <source>Too many failed login attempts, please try again in %minutes% minutes.</source>
       <target>Massa intents d'inici de sessió fallits, si us plau torneu-ho a provar en %minutes% minuts.</target>
</trans-unit>

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 5.4 milestone Jun 27, 2024
@nicolas-grekas
Copy link
Member

Thank you @umigam3.

@nicolas-grekas nicolas-grekas merged commit ef3d8e7 into symfony:5.4 Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants