[Notifier] Add Sipgate bridge

[sakul95]

Q	A
Branch?	7.2
Bug fix?	no
New feature?	yes
Deprecations?	no
License	MIT

Added a new notifier bridge for sipgate.

[OskarStark]

Not sure this should be in require section, but rather replace?

cc @stof

[OskarStark]

Thank you, I left some comments.

Can you also create a docs and recipes PR?

[sakul95]

Thank you, I left some comments.

Can you also create a docs and recipes PR?

Yes sure, I have not created a recipe yet so will read into it first.

[sakul95]

@OskarStark

Docs: symfony/symfony-docs#20018
Recipe: symfony/recipes#1323

Is this the correct way to do this?

[sakul95]

@OskarStark Maybe you can answer me two more questions:

1. Is it normal that 3 of the tests fail and if not, what can I do to fix these?

2. The recipe tests fail because the missing package on packagist. Shall I upload the package there or how is the workflow regarding those optional parts of symfony?

Best regards
Lukas

[fabpot]

@OskarStark Maybe you can answer me two more questions:

1. Is it normal that 3 of the tests fail and if not, what can I do to fix these?

You can ignore all errors that are not related to your work.

2. The recipe tests fail because the missing package on packagist. Shall I upload the package there or how is the workflow regarding those optional parts of symfony?

This will be automatically fixed when I will submit the package. Nothing to do on your side.

Best regards Lukas

[xabbuh]

Is it normal that 3 of the tests fail and if not, what can I do to fix these?

The failures in the „Verify Packages“ job are related. Looks like some files are missing. You can take inspiration from other existing bridges.

[fabpot]

There are some hidden useful information in the broken tests:

  File src/Symfony/Component/Notifier/Bridge/Sipgate/.gitattributes does not exist
  File src/Symfony/Component/Notifier/Bridge/Sipgate/.gitignore does not exist
  File src/Symfony/Component/Notifier/Bridge/Sipgate/phpunit.xml.dist does not exist

[sakul95]

I've added the missing files but the Verify Packages check still fails, this time because of "Composer.json's replace section needs to contain symfony/sipgate-notifier".

I have read into the composer schema and also looked into other comparable packages and can't find a clue why I should do that.

Of course I could simply add it but that does not seem to be right, maybe you can give me some insight for that?
(Maybe it correlates with comment of @OskarStark #57627 (comment))

[fabpot]

Thank you @sakul95.