bug #1297 [TwigComponent] Fix DataCollector return types (smnandre)

This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Fix DataCollector return types | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1296 | License | MIT Fix notices appears due to badly method type coercion (float -> int) Commits ------- 1409bda Fix DataCollector return types
symfony · Dec 1, 2023 · ff864e6 · ff864e6
2 parents 1ef2337 + 1409bda
commit ff864e6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/TwigComponent/src/DataCollector/TwigComponentDataCollector.php b/src/TwigComponent/src/DataCollector/TwigComponentDataCollector.php
@@ -88,9 +88,9 @@ public function getRenderCount(): int
         return $this->data['render_count'] ?? 0;
     }
 
-    public function getRenderTime(): int
+    public function getRenderTime(): float
     {
-        return $this->data['render_time'] ?? 0;
+        return (float) ($this->data['render_time'] ?? 0);
     }
 
     private function collectDataFromLogger(): void
@@ -149,7 +149,7 @@ private function collectDataFromLogger(): void
                 $renders[$renderId] += [
                     'render_end' => $profile[0],
                     'render_time' => $renderTime,
-                    'render_memory' => $profile[1],
+                    'render_memory' => (int) $profile[1],
                 ];
 
                 ++$components[$componentName]['render_count'];

diff --git a/src/TwigComponent/templates/Collector/twig_component.html.twig b/src/TwigComponent/templates/Collector/twig_component.html.twig
@@ -125,7 +125,7 @@
             <span class="sf-toolbar-value">{{ collector.renderCount }}</span>
             <span class="sf-toolbar-info-piece-additional-detail">
                 <span class="sf-toolbar-label">in</span>
-                <span class="sf-toolbar-value">{{ collector.renderTime }}</span>
+                <span class="sf-toolbar-value">{{ collector.renderTime|round }}</span>
                 <span class="sf-toolbar-label">ms</span>
             </span>
         {% endset %}
@@ -165,7 +165,7 @@
             <div class="metric-divider"></div>
             <div class="metric-group">
                 {{ _self.metric(collector.renderCount, "Render Count") }}
-                {{ _self.metric(collector.renderTime, "Render Time", "ms") }}
+                {{ _self.metric(collector.renderTime|round, "Render Time", "ms") }}
             </div>
             <div class="metric-divider"></div>
             <div class="metric-group">

diff --git a/src/TwigComponent/tests/Unit/DataCollector/TwigComponentDataCollectorTest.php b/src/TwigComponent/tests/Unit/DataCollector/TwigComponentDataCollectorTest.php
@@ -51,7 +51,7 @@ public function testLateCollect(): void
         $this->assertIsIterable($dataCollector->getRenders());
         $this->assertEmpty($dataCollector->getRenders());
 
-        $this->assertSame(0, $dataCollector->getRenderTime());
+        $this->assertEquals(0.0, $dataCollector->getRenderTime());
     }
 
     public function testReset(): void