-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TwigComponent] Poorly formatted deprecation in toolbar #1296
Comments
As i said there, i'llfix tonight. The weird thing is i cannot reproduce myself ... |
Could you share the TwigComponent profiler screen ? (in private if needed) And the versions of profiler and twig-component you're on ? |
I forget how to test another fork/branch! "symfony/web-profiler-bundle": "dev-twig-component-profiler-int-float"
"repositories": {
"profiler": {
"type": "vcs",
"url": "[email protected]:smnandre/ux.git"
}, I get composer update Problem 1 Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions. even with minimum-stability set to dev. |
As UX is on a monorepo, it can be a bit trickier i guess What i advice you is: Let's say your app is in /home/your-app Create a directory outside your app's one
ChoiceA: If you use the github cli
ChoiceB: or if you want to do it manuallyDownload the source code of the UX monorepo (of my PR) link the symfony UX packages to your vendors
test if everything is OKrestore your vendors where they were
Update: just to insist, it is not in the profiler component, but in the TwigComponent Every component has its own code related to the profiler |
This PR was merged into the 2.x branch. Discussion ---------- [TwigComponent] Fix DataCollector return types | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | Fix #1296 | License | MIT Fix notices appears due to badly method type coercion (float -> int) Commits ------- 1409bda Fix DataCollector return types
Symfony version(s) affected
6.4-RC
Description
I'm seeing a deprecation error in the toolbar that is poorly formatted
Even in the profiler page, it looks wrong:
The actual error is in vendor/symfony/ux-twig-component/src/DataCollector/TwigComponentDataCollector.php
on line 93, which I imagine will get fixed soon, but a related question is why this deprecation is showing up as it is.
How to reproduce
I can provide a repo if that helps, but at the moment I haven't been able to reproduce it with a simple repo.
(This issue was originally reported at symfony/symfony#52757)
The text was updated successfully, but these errors were encountered: