-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Allow binding LiveProp to URL query parameter #1230
Merged
weaverryan
merged 1 commit into
symfony:2.x
from
squrious:live-component/live-prop-url-binding
Dec 19, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
src/LiveComponent/assets/dist/Component/plugins/QueryStringPlugin.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import Component from '../index'; | ||
import { PluginInterface } from './PluginInterface'; | ||
interface QueryMapping { | ||
name: string; | ||
} | ||
export default class implements PluginInterface { | ||
private readonly mapping; | ||
constructor(mapping: { | ||
[p: string]: QueryMapping; | ||
}); | ||
attachToComponent(component: Component): void; | ||
} | ||
export {}; |
9 changes: 9 additions & 0 deletions
9
src/LiveComponent/assets/dist/Component/plugins/QueryStringPluging.d.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import Component from '../index'; | ||
import { PluginInterface } from './PluginInterface'; | ||
export default class implements PluginInterface { | ||
private element; | ||
private mapping; | ||
attachToComponent(component: Component): void; | ||
private registerBindings; | ||
private updateUrl; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export declare class UrlUtils extends URL { | ||
has(key: string): boolean; | ||
set(key: string, value: any): void; | ||
get(key: string): any | undefined; | ||
remove(key: string): void; | ||
private getData; | ||
private setData; | ||
} | ||
export declare class HistoryStrategy { | ||
static replace(url: URL): void; | ||
} |
31 changes: 31 additions & 0 deletions
31
src/LiveComponent/assets/src/Component/plugins/QueryStringPlugin.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import Component from '../index'; | ||
import { PluginInterface } from './PluginInterface'; | ||
import { UrlUtils, HistoryStrategy } from '../../url_utils'; | ||
|
||
interface QueryMapping { | ||
/** | ||
* URL parameter name | ||
*/ | ||
name: string, | ||
} | ||
|
||
export default class implements PluginInterface { | ||
constructor(private readonly mapping: {[p: string]: QueryMapping}) {} | ||
|
||
attachToComponent(component: Component): void { | ||
component.on('render:finished', (component: Component) => { | ||
const urlUtils = new UrlUtils(window.location.href); | ||
const currentUrl = urlUtils.toString(); | ||
|
||
Object.entries(this.mapping).forEach(([prop, mapping]) => { | ||
const value = component.valueStore.get(prop); | ||
urlUtils.set(mapping.name, value); | ||
}); | ||
|
||
// Only update URL if it has changed | ||
if (currentUrl !== urlUtils.toString()) { | ||
HistoryStrategy.replace(urlUtils); | ||
} | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be updated. It looks like it has not been released in v2.13.3: https://github.com/symfony/ux/blob/v2.13.3/src/LiveComponent/CHANGELOG.md