Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwigComponent] Allow trailing coma in "props" tags #1298

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[TwigComponent] Allow trailing coma in "props" tags #1298

merged 1 commit into from
Dec 1, 2023

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? not really
Issues Fix #1286
License MIT

Allow trailing comas in props tag

{% props 
    foo = 'foo',
    bar = 'bar',
%}

WebMamba
WebMamba approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@WebMamba WebMamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smnandre

@weaverryan weaverryan force-pushed the feat/allow-props-trailing-comas branch from c551b23 to 799df54 Compare December 1, 2023 20:15
@weaverryan
Copy link
Member

Thank you Simon! That was annoying me too :)

@weaverryan weaverryan merged commit f60079d into symfony:2.x Dec 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdreesen jdreesen jdreesen left review comments

@WebMamba WebMamba WebMamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TwigComponent] {% props syntax should allow dangling commas
4 participants
@smnandre @weaverryan @jdreesen @WebMamba