[LiveComponent] make serializer optional #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WebMamba
commented
Dec 10, 2023
WebMamba
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| Issues | |
| License | MIT |
weaverryan
reviewed
Dec 12, 2023
| @@ -374,8 +378,6 @@ private function dehydrateValue(mixed $value, LivePropMetadata $propMetadata, ob | |||
| } | |||
|
|
|||
| if (!$this->isValueValidDehydratedValue($value)) { | |||
| $badKeys = $this->getNonScalarKeys($value, $propMetadata->getName()); | |||
There was a problem hiding this comment.
this getNonScalarKeys() is now also unused, so let's remove that too :)
| @@ -354,6 +354,10 @@ private function dehydrateValue(mixed $value, LivePropMetadata $propMetadata, ob | |||
| } | |||
|
|
|||
| if ($propMetadata->useSerializerForHydration()) { | |||
| if (!interface_exists(NormalizerInterface::class)) { | |||
| throw new \LogicException(sprintf('The LiveProp "%s" on component "%s" is using the serializer to hydrate, but the Serializer component is not installed. Try running "composer require symfony/serializer".', $propMetadata->getName(), $parentObject::class)); | |||
There was a problem hiding this comment.
Let's mention the specific option name:
Suggested change
| throw new \LogicException(sprintf('The LiveProp "%s" on component "%s" is using the serializer to hydrate, but the Serializer component is not installed. Try running "composer require symfony/serializer".', $propMetadata->getName(), $parentObject::class)); | |
| throw new \LogicException(sprintf('The LiveProp "%s" on component "%s" has "useSerializerForHydration: true" but the Serializer component is not installed. Try running "composer require symfony/serializer".', $propMetadata->getName(), $parentObject::class)); |
weaverryan
force-pushed
the
live-components-make-serializer-optional
branch
from
92518df to
a6f00ea
Compare
|
Thanks Matheo~ |
weaverryan
added a commit
that referenced
this pull request
Dec 17, 2023
…ializer (smnandre) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [LiveComponent] Make LiveComponentHydrator work without Serializer | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | License | MIT Allow nullable "serializer" argument in LiveComponentHydrator constructor. (fix #1340 and complete #1327) Commits ------- 10ca442 [LiveComponent] Make LiveComponentHydrator work without Serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.