[StimulusBundle] Add support for typescript controllers #1335
Conversation
evertharmeling
force-pushed
the
ts-support
branch
from
da0e8b8 to
ce3f0e0
Compare
|
Good stuff - thank you @evertharmeling! |
| @@ -1,5 +1,9 @@ | |||
| # CHANGELOG | |||
|
|
|||
| ## 2.x | |||
|
|
|||
| - Added Typescript controllers support | |||
There was a problem hiding this comment.
I think there should be doc somewhere explaining a bit more this change.. as it could be disappointing for some :)
There was a problem hiding this comment.
Good point - just a bit more clarity on how .ts controller files are now located (if you use TypeScript bundle to process in the first place)
There was a problem hiding this comment.
Yeah fair enough, I'll try to add some documentation
EDIT: #1345
| @@ -1,5 +1,6 @@ | |||
| .php-cs-fixer.cache | |||
| .phpunit.result.cache | |||
| composer.lock | |||
| var/ | |||
There was a problem hiding this comment.
If not necessary, could this be reverted ?
There was a problem hiding this comment.
I'd added it because when running the testsuite it created a failure html-file in var/browser/source and to not accidentally add it git. I'll create a PR.
…armeling, weaverryan) This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle] Added docs on TypeScript support | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Issues | #1335 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT Follow-up on #1335, added more info on usage of TypeScript controllers support. Commits ------- 237164f Tweaking wording 60c0b8e [StimulusBundle] Added docs about Typescript controller usage 3724401 [StimulusBundle] Revert adding var/ to .gitignore
To be able to use
typescript-controllers we need to be able to load those controllers. This PR adds support for loading*.tsfiles.Full support for
typescript-controllers needs the sensiolabs/typescript-bundle to compile the controllers.A reproducer project can be found here. It needs this PR to run.
Also see this slack conversation.