-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LiveComponent] Fix test Kernel deprecations #1369
Conversation
a165725
to
203f5e1
Compare
Any idea @kbond @weaverryan ? |
(we should merge this one "now" if we need time to figure out the phpcs bug, as this PR fixes the other CI fails) |
Thanks Simon. |
Regarding the cs issue - looks the anon class must be the culprit. Bug in symfony/property-access maybe? |
Hmm I feared that answer haha… well, time to discover the internals of a new component :) |
I think the easy fix for now would be to use a concrete class instead of anon in this test. |
Ok, will do tonight |
Fixed in #1371 |
This PR was merged into the 2.x branch. Discussion ---------- fix: use concrete class (instead of anon) for test | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | #1369 | License | MIT `symfony/property-accessor` doesn't appear to parse object types from anon class props when imported. This is a quick fix to get the CI passing. Commits ------- e9046f2 fix: use concrete class (instead of anon) for test
Thank you @kbond ! |
Fix some Kernel deprecation.
But the CS remains, because (and it's kinda weird) PhpCSFixer says
But if we do that ....