[LiveComponent] Fix trim classes in live_controller.js #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jan 7, 2024
src/LiveComponent/assets/src/Component/plugins/LoadingPlugin.ts
Outdated
Show resolved
Hide resolved
src/LiveComponent/assets/src/Component/plugins/LoadingPlugin.ts
Outdated
Show resolved
Hide resolved
src/LiveComponent/assets/src/Component/plugins/LoadingPlugin.ts
Outdated
Show resolved
Hide resolved
smnandre
force-pushed
the
fix/live-component-trim
branch
2 times, most recently
from
ddbab62 to
d618d46
Compare
And various CS / minor fixes while i looked at the code... you may refuse as it's way over the original scope :)
smnandre
force-pushed
the
fix/live-component-trim
branch
from
4772ad6 to
3ff5112
Compare
|
Thank you Simon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix trim classes in live_controller.js .. . and should solve #1358
Add various CS / minor fixes while i looked at the code... you may refuse as it's way over the original scope :)