Update index.rst Usage React with AssetMapper #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completing the documentation of usage with UX React with Asset Mapper
Completing the documentation of usage with UX React with Asset Mapper
WebMamba
reviewed
Jul 15, 2024
Comment on lines
+107
to
+126
| 1- Create package.json in your project. This file is not included in the **Standard package**. (code below) | ||
|
|
||
| .. code-block:: json-object | ||
|
|
||
| { | ||
| "devDependencies": { | ||
| "@babel/cli": "^7.21.5", | ||
| "@babel/core": "^7.21.8", | ||
| "@babel/preset-react": "^7.18.6", | ||
| "svelte": "^3.59.1" | ||
| }, | ||
| "license": "MIT", | ||
| "private": true, | ||
| "scripts": { | ||
| "build": "yarn build-react && yarn build-svelte", | ||
| "build-react": "babel assets/react --out-dir assets/build/react --presets=@babel/preset-react", | ||
| "build-svelte": "node bin/compile_svelte.js" | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we don't need to add the content of the package.json. Let's stay simple and say that we need a package.json and to install few dependencies.
| JavaScript files: | ||
|
|
||
| .. code-block:: yaml | ||
|
|
||
| # config/packages/react.yaml | ||
| # config/packages/asset_mapper.yaml |
There was a problem hiding this comment.
Why change the file name ?
|
|
||
| .. code-block:: terminal | ||
|
|
||
| $ npm install |
There was a problem hiding this comment.
You use npm and below yarn. Let's stay on yarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing the documentation of usage with UX React with Asset Mapper