[LiveComponent] Check secret is not empty + add [SensitiveParameter] #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter] Improve security before we allow secret customization for LiveComponents (cf symfony#2453) I consider this a fix as passing an empty string for secret produce the same hash as passing null... which is deprecated for obvious reasons.
carsonbot
added
Bug
|
(fabbot errors unrelated) |
This was referenced Dec 21, 2024
Kocal
approved these changes
Dec 21, 2024
carsonbot
added
Status: Reviewed
kbond
approved these changes
Dec 23, 2024
smnandre
added a commit
that referenced
this pull request
Dec 24, 2024
… and checksums (smnandre) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [LiveComponent] Allow configuring secret for fingerprints and checksums | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Issues | Fix #2453 | License | MIT Allow to configure a dedicated secret (used in FingerprintCalculator and LiveComonentHydrator) Suggested by `@dkarlovi` in #2453 Implementation inspired by [symfony #56840](symfony/symfony#56840) Should be merged _after_ #2461 Commits ------- a641a2e [LiveComponent] Allow configuring secret for fingerprints and checksums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve security before we allow secret customization for LiveComponents (cf #2453)
I consider this a fix as passing an empty string for secret produces the same hash as passing null... which is deprecated for obvious reasons.