[LiveComponent] Prevent __component
property to be serialized when called JSON.stringify()
#2537
+9
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://symfony-devs.slack.com/archives/C01FN4EQNLX/p1738238525455439
With some RUM tools that listen user interactions, some of them can
![image](https://private-user-images.githubusercontent.com/2103975/408209896-0538ebe7-8fff-4104-aacd-5954661cea0d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNjEyODcsIm5iZiI6MTczOTA2MDk4NywicGF0aCI6Ii8yMTAzOTc1LzQwODIwOTg5Ni0wNTM4ZWJlNy04ZmZmLTQxMDQtYWFjZC01OTU0NjYxY2VhMGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDAyOTQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGU1YmExN2NmYzMyYTQxYjNiNWVlNzM4OGIwYTJjZmUyODc2OGYwNDMxNjhlZmEwMTY4NDU3NDZhMDdmMjdlMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-cPFcxRV1O7rE0-6ysdprL6-RhygT_KBWrfLI4GlrGA)
JSON.stringify()
their payload. But if their payload contains an HTML element with the property__component
(which represents aProxy
to theLiveComponent
instance), then it tries to be serialized and lead to an error by trying to call an actiontoJSON
and trigger an XHR request to/toJSON
:Let's change the property assignment with
![image](https://private-user-images.githubusercontent.com/2103975/408211988-dc18c06b-0793-424c-b561-b72647ec4d93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNjEyODcsIm5iZiI6MTczOTA2MDk4NywicGF0aCI6Ii8yMTAzOTc1LzQwODIxMTk4OC1kYzE4YzA2Yi0wNzkzLTQyNGMtYjU2MS1iNzI2NDdlYzRkOTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMDAyOTQ3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTVhMTk1ZmFjZDg1ZTFjZTg1MDNkM2Q5ZjBjNzM1NjljMGViMzdkYjZjOTgwNWIzNDgwMTNmY2NmOGI2YWUxOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.uctucDQtlVfsCb_faIdjsvwyodi7W3_1ZMZiffq7JZ0)
Object.defineProperty()
, so the property is not enumarable and so not serialized whenJSON.stringify()
is called:cc @jwage