Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athib/fix deprecated warning #106

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

athib
Copy link
Contributor

@athib athib commented May 23, 2024

Adding return types on SensioLabs\Insight\Sdk\Model\Violations to fix the deprecated notices on analysis

Deprecated: Return type of SensioLabs\Insight\Sdk\Model\Violations::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/insight/Sdk/Model/Violations.php on line 25
Deprecated: Return type of SensioLabs\Insight\Sdk\Model\Violations::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/insight/Sdk/Model/Violations.php on line 30

@nicolas-grekas nicolas-grekas merged commit 872986e into symfonycorp:master Jun 24, 2024
5 of 12 checks passed
@nicolas-grekas
Copy link
Contributor

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants