Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2+ #55

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

PHP 7.2+ #55

wants to merge 5 commits into from

Conversation

animaux
Copy link

@animaux animaux commented Dec 1, 2020

Fix for PHP 7.2+ and count()

Alexander Rutz and others added 5 commits November 30, 2020 21:35
On PHP 7.2 `is_countable` creates an undefined function. `is_countable` is not available until PHP 7.3, <https://www.php.net/manual/en/function.is-countable.php>. 

In PHP 7.3, I get this error... "count(): Parameter must be an array or an object that implements Countable".

BUT, I found this... instead of `is_countable($value)`, **it works with `array($value)`** which I got from this Stack Overflow post, <https://stackoverflow.com/a/59818642>.
class.xmlimporter.php - switch is_countable() to array()
Fixed the less than character as < is invalid and should be &lt; 

That character caused an error in the installation process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants