Avoid commenting on merged dependabot PRs #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data
The webapp.py code expects event.data['pull_request']['user']['login'] to exist,
but many tests were missing this 'user' key in their pull_request objects,
causing KeyError exceptions.
Added the missing 'user': {'login': 'asmeurer'} key to all affected test functions.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Fixed remaining test failures by: - Removing outdated '(version not found!)' text from expected comment bodies - Fixing incorrect test logic that was checking wrong PR description variant All webapp tests now pass (63/63). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Added missing asyncio_default_fixture_loop_scope setting in pyproject.toml to properly configure pytest-asyncio for async test functions. This resolves the "async def functions are not natively supported" errors on CI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add test_dependabot_pr_noop to verify dependabot PRs get success status without release notes processing - Add test_dependabot_pr_closed_skip to verify merged dependabot PRs are properly skipped - Tests confirm the fix prevents dependabot PRs from causing release notes check failures 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Hard to test this without merging but I think this should fix things like sympy/sympy#28367 (comment) from happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.