-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unjankify a few things #359
base: master
Are you sure you want to change the base?
Conversation
- Fill all of height of idea card on home page - Fix IE Jank spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good; can I get a picture of the visual changes that happened as a result of this? We don't really need before/after pictures but something that shows what changed would be good.
IE only: Issue #327 still exists. This can be seen on the create idea page, it appears to be lower than before. |
These are all pretty nit picky. Choose what you want to fix. No major issues. Done testing! |
The logo issue is a non-starter. I'm not going to add image optimization for a shittier browser. We display a banner that says "Use a better browser". |
The login spacing is also a non-starter. It doesn't look bad anymore. The bigger issue is that the button isn't in the right place in IE. But whatever, again, that browser sucks deer dick. If anything, we should make the banner to use a non shitty browser even larger and bright yellow. |
#327 is probably also a non-starter. Make that "use a better browser" banner larger and call it a day. |
@alanlgirard it's probably worth looking into the extra spacing on the card after the title. |
@alanlgirard learn looks okay on chrome, evidently not well on IE. I care more about this than the other IE issues since it blocks the main purpose of the page but I care about this way less than the extra spacing on the idea card which is also minor. It's up to you if you want to fix it or not. |
Approved by me! |
@alanlgirard status? |
@alanlgirard
Correct? @YashdalfTheGray We really need to get this merged and up and running on the machine under my desk before you leave. Pending Alan's response, what are your thoughts on merging this, making a 1.1 label and getting it up so we can test it? Phrasing. |
I'm okay with it once the conflicts are solved? |
Home page idea card updates
Fixed #327 to fill height with card
@davethenipper: Pull this down and check IE